Recherche avancée

Sur d’autres sites (5129)

• avcodec : v4l2_m2m : fix races around freeing data on close

  9 janvier 2018, par Mark Thompson

  avcodec : v4l2_m2m : fix races around freeing data on close
  Refcount all of the context information. This also fixes a potential
  
  segmentation fault when accessing freed memory  (buffer returned after
  
  the codec has been closed).
  Tested-by : Jorge Ramirez-Ortiz <jorge.ramirez.ortiz@gmail.com>
  

  • [DH] libavcodec/v4l2_buffers.c
  • [DH] libavcodec/v4l2_buffers.h
  • [DH] libavcodec/v4l2_m2m.c
  • [DH] libavcodec/v4l2_m2m.h
  • [DH] libavcodec/v4l2_m2m_dec.c
  • [DH] libavcodec/v4l2_m2m_enc.c

• avformat/matroskaenc : Remove allocations for Attachments

  29 décembre 2019, par Andreas Rheinhardt

  avformat/matroskaenc : Remove allocations for Attachments
  If there are Attachments to write, the Matroska muxer currently
  
  allocates two objects : An array that contains an entry for each
  
  AttachedFile containing just the stream index of the corresponding
  
  stream and the FileUID used for this AttachedFile ; and a structure with
  
  a pointer to said array and a counter for said array. These uids are
  
  generated via code special to Attachments : It uses an AVLFG in the
  
  normal and a sha of the attachment data in the bitexact case. (Said sha
  
  requires an allocation, too.)
  But now that an uid is generated for each stream in mkv_init(), there is
  
  no need any more to use special code for generating the FileUIDs of
  
  AttachedFiles : One can simply use the uid already generated for the
  
  corresponding stream. And this makes the whole allocations of the
  
  structures for AttachedFiles as well as the structures itself superfluous.
  
  They have been removed.
  In case AVFMT_FLAG_BITEXACT is set, the uids will be different from the
  
  old ones which is the reason why the FATE-test lavf-mkv_attachment
  
  needed to be updated. The old method had the drawback that two
  
  AttachedFiles with the same data would have the same FileUID.
  
  The new one doesn't.
  Also notice that the dynamic buffer used to write the Attachments leaks
  
  if an error happens when writing the buffer. By removing the
  
  allocations potential sources of errors have been removed.
  Signed-off-by : Andreas Rheinhardt <andreas.rheinhardt@gmail.com>
  

  • [DH] libavformat/matroskaenc.c
  • [DH] tests/ref/lavf/mkv_attachment

• lavc/encode : add an encoder-specific get_buffer() variant

  23 mars 2022, par Anton Khirnov

  lavc/encode : add an encoder-specific get_buffer() variant
  Several encoders (roqvideo, svq1, snow, and the mpegvideo family)
  
  currently call ff_get_buffer(). However this function is written
  
  assuming it is called by a decoder. Though nothing has been obviously
  
  broken by this until now, that may change in the future.
  To avoid potential future issues, introduce a simple encode-specific
  
  wrapper around avcodec_default_get_buffer2() and enforce its use in
  
  encoders.
  

  • [DH] libavcodec/decode.c
  • [DH] libavcodec/encode.c
  • [DH] libavcodec/encode.h
  • [DH] libavcodec/mpegpicture.c
  • [DH] libavcodec/roqvideoenc.c
  • [DH] libavcodec/snow.c
  • [DH] libavcodec/svq1enc.c