Recherche avancée

Sur d’autres sites (5745)

• avcodec/ffv1 : Move ffv1_template.c inclusion to dec/enc templates

  16 octobre 2022, par Andreas Rheinhardt

  avcodec/ffv1 : Move ffv1_template.c inclusion to dec/enc templates
  Both the FFV1 decoder and encoder use a template of their own
  
  to generate code multiple times. They also use a common template,
  
  used by both decoder and encoder templates which is currently
  
  instantiated in ffv1.h (and therefore also in ffv1.c, which
  
  doesn't need it at all).
  All these templates have the prerequisite that two macros
  
  are defined, namely RENAME() and TYPE. The codec-specific
  
  templates call the functions generated via the common template
  
  via the RENAME() macro and therefore the macros used for
  
  the common template must coincide with the macros used for
  
  the codec-specific templates. But then it is better to not
  
  instantiate the common template in ffv1.h, but in the codec
  
  specific templates.
  Signed-off-by : Andreas Rheinhardt <andreas.rheinhardt@outlook.com>
  

  • [DH] libavcodec/ffv1.h
  • [DH] libavcodec/ffv1dec_template.c
  • [DH] libavcodec/ffv1enc_template.c

• avcodec/mpegvideo : Split ff_mpv_reconstruct_mb() into de/encoder part

  14 octobre 2022, par Andreas Rheinhardt

  avcodec/mpegvideo : Split ff_mpv_reconstruct_mb() into de/encoder part
  This has the advantage of not having to check for whether
  
  a given MpegEncContext is actually a decoder or an encoder
  
  context at runtime.
  To do so, mpv_reconstruct_mb_internal() is moved into a new
  
  template file that is included by both mpegvideo_enc.c
  
  and mpegvideo_dec.c ; the decoder-only code (mainly lowres)
  
  are also moved to mpegvideo_dec.c. The is_encoder checks are
  
  changed to #if IS_ENCODER in order to avoid having to include
  
  headers for decoder-only functions in mpegvideo_enc.c.
  This approach also has the advantage that it is easy to adapt
  
  mpv_reconstruct_mb_internal() to using different structures
  
  for decoders and encoders (e.g. the check for whether
  
  a macroblock should be processed for the encoder or not
  
  uses MpegEncContext elements that make no sense for decoders
  
  and should not be part of their context).
  Signed-off-by : Andreas Rheinhardt <andreas.rheinhardt@outlook.com>
  

  • [DH] libavcodec/mpeg_er.c
  • [DH] libavcodec/mpegvideo.c
  • [DH] libavcodec/mpegvideo.h
  • [DH] libavcodec/mpegvideo_dec.c
  • [DH] libavcodec/mpegvideo_enc.c
  • [DH] libavcodec/mpegvideodec.h
  • [DH] libavcodec/mpv_reconstruct_mb_template.c

• swscale/input : Avoid calls to av_pix_fmt_desc_get()

  8 septembre 2022, par Andreas Rheinhardt

  swscale/input : Avoid calls to av_pix_fmt_desc_get()
  Up until now, libswscale/input.c used a macro to read
  
  an input pixel which involved a call to av_pix_fmt_desc_get()
  
  to find out whether the input pixel format is BE or LE
  
  despite this being known at compile-time (there are templates
  
  per pixfmt). Even worse, these calls are made in a loop,
  
  so that e.g. there are six calls to av_pix_fmt_desc_get()
  
  for every pair of UV pixel processed in
  
  rgb64ToUV_half_c_template().
  This commit modifies these macros to ensure that isBE()
  
  is evaluated at compile-time. This saved 9743B of .text
  
  for me (GCC 11.2, -O3). For a simple RGB64LE->YUV420P
  
  transformation like
  
  ffmpeg -f lavfi -i haldclutsrc,format=rgba64le -pix_fmt yuv420p \
  
   threads 1  -t 1:00  -f null -
  
  the amount of decicycles spent in rgb64LEToUV_half_c
  
  (which is created via the template mentioned above)
  
  decreases from 19751 to 5341 ; for RGBA64BE the number
  
  went down from 11945 to 5393. For shared builds (where
  
  the call to av_pix_fmt_desc_get() is indirect) the old numbers
  
  are 15230 for RGBA64BE and 27502 for RGBA64LE, whereas
  
  the numbers with this patch are indistinguishable from
  
  the numbers from a static build.
  Also make the macros that are touched conform to the
  
  usual convention of using uppercase names while just at it.
  Reviewed-by : Anton Khirnov <anton@khirnov.net>
  
  Reviewed-by : Paul B Mahol <onemda@gmail.com>
  
  Reviewed-by : Michael Niedermayer <michael@niedermayer.cc>
  
  Signed-off-by : Andreas Rheinhardt <andreas.rheinhardt@outlook.com>
  

  • [DH] libswscale/input.c