Recherche avancée

Sur d’autres sites (5476)

• Revert "avcodec : add FF_CODEC_CAP_INIT_CLEANUP for all codecs which use ff_mpv_common...

  24 décembre 2020, par Andreas Rheinhardt

  Revert "avcodec : add FF_CODEC_CAP_INIT_CLEANUP for all codecs which use ff_mpv_common_init()"
  This mostly reverts commit 4b2863ff01b1fe93d9a518523c9098d17a9d8c6f.
  
  Said commit removed the freeing code from ff_mpv_common_init(),
  
  ff_mpv_common_frame_size_change() and ff_mpeg_framesize_alloc() and
  
  instead added the FF_CODEC_CAP_INIT_CLEANUP to several codecs that use
  
  ff_mpv_common_init(). This introduced several bugs :
  a) Several decoders using ff_mpv_common_init() in their init function were
  
  forgotten : This affected FLV, Intel H.263, RealVideo 3.0 and V4.0 as well as
  
  VC-1/WMV3.
  
  b) ff_mpv_common_init() is not only called from the init function of
  
  codecs, it is also called from AVCodec.decode functions. If an error
  
  happens after an allocation has succeeded, it can lead to memleaks ;
  
  furthermore, it is now possible for the MpegEncContext to be marked as
  
  initialized even when ff_mpv_common_init() returns an error and this can
  
  lead to segfaults because decoders that call ff_mpv_common_init() when
  
  decoding a frame can mistakenly think that the MpegEncContext has been
  
  properly initialized. This can e.g. happen with H.261 or MPEG-4.
  
  c) Removing code for freeing from ff_mpeg_framesize_alloc() (which can't
  
  be called from any init function) can lead to segfaults because the
  
  check for whether it needs to allocate consists of checking whether the
  
  first of the buffers allocated there has been allocated. This part has
  
  already been fixed in 76cea1d2ce3f23e8131c8664086a1daf873ed694.
  
  d) ff_mpv_common_frame_size_change() can also not be reached from any
  
  AVCodec.init function ; yet the changes can e.g. lead to segfaults with
  
  decoders using ff_h263_decode_frame() upon allocation failure, because
  
  the MpegEncContext will upon return be flagged as both initialized and
  
  not in need of reinitialization (granted, the fact that
  
  ff_h263_decode_frame() clears context_reinit before the context has been
  
  reinited is a bug in itself). With the earlier version, the context
  
  would be cleaned upon failure and it would be attempted to initialize
  
  the context again in the next call to ff_h263_decode_frame().
  While a) could be fixed by adding the missing FF_CODEC_CAP_INIT_CLEANUP,
  
  keeping the current approach would entail adding cleanup code to several
  
  other places because of b). Therefore ff_mpv_common_init() is again made
  
  to clean up after itself ; the changes to the wmv2 decoder and the SVQ1
  
  encoder have not been reverted : The former fixed a memleak, the latter
  
  allowed to remove cleanup code.
  Fixes : double free
  
  Fixes : ff_free_picture_tables.mp4
  
  Fixes : ff_mpeg_update_thread_context.mp4
  
  Fixes : decode_colskip.mp4
  
  Fixes : memset.mp4
  Reviewed-by : Michael Niedermayer <michael@niedermayer.cc>
  
  Signed-off-by : Andreas Rheinhardt <andreas.rheinhardt@gmail.com>
  

  • [DH] libavcodec/h261dec.c
  • [DH] libavcodec/h263dec.c
  • [DH] libavcodec/mpeg12dec.c
  • [DH] libavcodec/mpeg4videodec.c
  • [DH] libavcodec/mpegvideo.c
  • [DH] libavcodec/msmpeg4dec.c
  • [DH] libavcodec/rv10.c

• typeError when using ffmpeg with buffer in NodeJS ["argument must be of type string or an instance of Buffer"]

  16 mars 2021, par coolps811

  I am trying to covert buffer data into the correct mp4 video format. However I am getting an error : "UnhandledPromiseRejectionWarning : TypeError [ERR_INVALID_ARG_TYPE] : The "data" argument must be of type string or an instance of Buffer, TypedArray, or DataView. Received an instance of FfmpegCommand". How can I fix this ?

  


  router.post("/download", (req, res, next) => {
  axios({
    method: "get",
    url: req.body.url,
    responseType: "arraybuffer",
  }).then(function (response) {
    const data = new Uint8Array(Buffer.from(response.data));

    const proc = new ffmpeg(data)
      .videoCodec("libx264")
      .outputOptions(["-movflags isml+frag_keyframe"])
      .toFormat("mp4")
      //.seekInput(offset) this is a problem with piping
      .on("error", function (err, stdout, stderr) {
        console.log("an error happened: " + err.message);
        console.log("ffmpeg stdout: " + stdout);
        console.log("ffmpeg stderr: " + stderr);
      })
      .on("end", function () {
        console.log("Processing finished !");
      })
      .on("progress", function (progress) {
        console.log("Processing: " + progress.percent + "% done");
      });

    fs.writeFile("Assets/test.mp4", proc, callback);
  });

  const callback = (err) => {
    if (err) throw err;
    console.log("It's saved!");
  };
});


  


• electron ffmpeg mas build "Illegal instruction : 4"

  8 mars 2021, par Martin

  I am trying to release an electron app on the Mac Apple Store (mas), my electron app uses ffmpeg to render videos. In order to release my app on the mac apple store, It needs to be sandboxed, and by default ffmpeg makes calls to external libraries so I need to statically build ffmpeg and package it with my app. My code is on the 'mas-ffmpeg-fix' branch : https://github.com/MartinBarker/digify/tree/mas-ffmpeg-fix

  


  My static ffmpeg build works before I build my app, but after running electron-builder build --mac, the ffmpeg executable now fails with Illegal instruction: 4

  


  This is the full timeline of building/packaging/submitting my app to the mac apple store and where the error first appears :

  


  


  • In Digify repo :

    


  


  • clone, configure, and build static ffpmeg : “sudo rm -rf ffmpeg-mac/ && npm run download-ffmpeg”

    


  


  • download-ffmpeg command is inside package.json and runs this :
git clone https://git.ffmpeg.org/ffmpeg.git ffmpeg-mac && cd ffmpeg-mac && ./configure pkg_config='pkg-config --static' --pkg-config-flags='--static' --libdir=/usr/local/lib --extra-version=ntd_20150128 --disable-shared --disable-lzma --enable-gpl --enable-pthreads --enable-nonfree --enable-libass --enable-libfdk-aac  --enable-libmp3lame  --enable-libx264 --enable-static --enable-filters --enable-runtime-cpudetect && make && cd ..

    


  


  • Check if any dylibb files in the static ffmpeg build with command : “otool -L ffmpeg-mac/ffmpeg | grep /usr/local”

    


  


  • If there are any, move them to folder in desktop, run ‘otool’ again to ensure there are no dynamic libraries, rebuild static ffmpeg.

    


  


  • there will now be a folder 'ffmpeg-mac' which contains static versions of ffmpeg and ffprobe

    


  


  


  Using ffmpeg with electron UI : works
Using Ffmpeg with command-line command :
/Users/martinbarker/Documents/projects/digify-new/ffmpeg-mac/ffmpeg -h
Works

  


  

  • Build mac mass app with “npm run build-mas“

  


  • When this command finishes it will output two files inside the /dist/mas/ folder : Digify.app and Digify-01.20.pkg (or whatever version number it is)
Ffmpeg command-line check :
/Users/martinbarker/Documents/projects/digify-new/dist/mas/Digify.app/Contents/Resources/ffmpeg -h
Illegal instruction : 4

  


  


  This is the first place the error appears, after building my mac mac-apple-store app, ffmpeg fails with this err.

  


  

  • Sign built app with .sh file : “sh mas-sign-script.sh”
view .sh file here

    

    • the .sh file will output Digify-mac.pkg

    


    


  


  • Easier command to both build & sign : “sudo rm -rf dist/mas/ && npm run build-mas && sh mas-sign-script.sh”

  


  • Upload the outputted “Digify-mac.pkg” file & submit to apple for review

  


  


  Once this app gets published in the store, if you download it and try to run an ffmpeg command with the electron UI, it fails with this error :

  


  /Applications/Digify.app/Contents/Resources/app.asar/node_modules/execa/lib/error.js:59 Uncaught (in promise) Error: Command failed with exit code 1: /Applications/Digify.app/Contents/Resources/ffmpeg -i /Users/martinbarker/Downloads/Felix Lebarty - Bobo/01. Bobo.mp3 -y -filter_complex concat=n=1:v=0:a=1 -c:a libmp3lame -b:a 320k /Users/martinbarker/Downloads/Felix Lebarty - Bobo/output-064237.mp3
ffmpeg version N-101191-g51a9f487ae-ntd_20150128 Copyright (c) 2000-2021 the FFmpeg developers
  built with Apple LLVM version 10.0.1 (clang-1001.0.46.4)
  configuration: pkg_config='pkg-config --static' --pkg-config-flags=--static --libdir=/usr/local/lib --extra-version=ntd_20150128 --disable-shared --disable-lzma --enable-gpl --enable-pthreads --enable-nonfree --disable-libass --enable-libfdk-aac --enable-libmp3lame --enable-libx264 --enable-static --enable-filters --enable-runtime-cpudetect
  libavutil      56. 65.100 / 56. 65.100
  libavcodec     58.125.100 / 58.125.100
  libavformat    58. 68.100 / 58. 68.100
  libavdevice    58. 12.100 / 58. 12.100
  libavfilter     7.107.100 /  7.107.100
  libswscale      5.  8.100 /  5.  8.100
  libswresample   3.  8.100 /  3.  8.100
  libpostproc    55.  8.100 / 55.  8.100
[mp3 @ 0x7feeae809c00] Estimating duration from bitrate, this may be inaccurate
Input #0, mp3, from '/Users/martinbarker/Downloads/Felix Lebarty - Bobo/01. Bobo.mp3':
  Metadata:
    comment         : 
    album           : Bobo
    artist          : Felix Lebarty
    title           : Funkytown Eklablog
    genre           : Boogie
    date            : 1984
  Duration: 00:05:19.53, start: 0.000000, bitrate: 320 kb/s
  Stream #0:0: Audio: mp3, 44100 Hz, stereo, fltp, 320 kb/s
/Users/martinbarker/Downloads/Felix Lebarty - Bobo/output-064237.mp3: Operation not permitted
    at makeError (/Applications/Digify.app/Contents/Resources/app.asar/node_modules/execa/lib/error.js:59)
    at handlePromise (/Applications/Digify.app/Contents/Resources/app.asar/node_modules/execa/index.js:114)
    at async file:/Applications/Digify.app/Contents/Resources/app.asar/src/js/newindex.js:1162


  


  Command failed with exit code 1: Operation not permitted