Recherche avancée

Sur d’autres sites (6303)

• Huge memory leak when filtering video with libavfilter

  29 mai 2017, par Captain Jack

  I have a relatively simple FFMPEG C program, to which a video frame is fed, processed via filter graph and sent to frame renderer.

  Here are some code snippets :

  /* Filter graph here */
  
  char args[512];
  
  enum AVPixelFormat pix_fmts[] = {AV_PIX_FMT_RGB32 };    
  
  AVFilterGraph   *filter_graph;
  
  avfilter_register_all();
  
  AVFilter *buffersrc  = avfilter_get_by_name("buffer");
  
  AVFilter *buffersink = avfilter_get_by_name("ffbuffersink");
  
  AVBufferSinkParams *buffersink_params;
  
  AVFilterInOut *outputs = avfilter_inout_alloc();
  
  AVFilterInOut *inputs  = avfilter_inout_alloc();
  
  filter_graph = avfilter_graph_alloc();
  
  
  
  snprintf(args, sizeof(args),
  
          "video_size=%dx%d:pix_fmt=%d:time_base=%d/%d:pixel_aspect=%d/%d",
  
          av->codec_ctx->width, av->codec_ctx->height, av->codec_ctx->pix_fmt,
  
          av->codec_ctx->time_base.num, av->codec_ctx->time_base.den,
  
          av->codec_ctx->sample_aspect_ratio.num, av->codec_ctx->sample_aspect_ratio.den);
  
  
  
  if(avfilter_graph_create_filter(&av->buffersrc_ctx, buffersrc, "in",args, NULL, filter_graph) < 0) 
  
  {
  
      fprintf(stderr, "Cannot create buffer source\n");
  
      return(0);
  
  }
  
  
  
   /* buffer video sink: to terminate the filter chain. */
  
  buffersink_params = av_buffersink_params_alloc();
  
  buffersink_params->pixel_fmts = pix_fmts;
  
  
  
  if(avfilter_graph_create_filter(&av->buffersink_ctx, buffersink, "out",NULL, buffersink_params, filter_graph) < 0) 
  
  {
  
      printf("Cannot create buffer sink\n");
  
      return(HACKTV_ERROR);
  
  }
  
  
  
    /* Endpoints for the filter graph. */
  
      outputs->name       = av_strdup("in");
  
      outputs->filter_ctx = av->buffersrc_ctx;
  
      outputs->pad_idx    = 0;
  
      outputs->next       = NULL;
  
  
  
      inputs->name       = av_strdup("out");
  
      inputs->filter_ctx = av->buffersink_ctx;
  
      inputs->pad_idx    = 0;
  
      inputs->next       = NULL;
  
  
  
  const char *filter_descr = "vflip";
  
  
  
      if (avfilter_graph_parse_ptr(filter_graph, filter_descr, &inputs, &outputs, NULL) < 0)
  
  {
  
      printf("Cannot parse filter graph\n");
  
      return(0);
  
  }
  
  
  
   if (avfilter_graph_config(filter_graph, NULL) < 0) 
  
  {
  
      printf("Cannot configure filter graph\n");
  
      return(0);
  
  }
  
  
  
  av_free(buffersink_params);
  
  avfilter_inout_free(&inputs);
  
  avfilter_inout_free(&outputs);

  The above code is called by these elsewhere :

  av->frame_in->pts = av_frame_get_best_effort_timestamp(av->frame_in);
  
  
  
  /* push the decoded frame into the filtergraph*/
  
  if (av_buffersrc_add_frame(av->buffersrc_ctx, av->frame_in) < 0) 
  
  {
  
      printf( "Error while feeding the filtdergraph\n");
  
      break;
  
   }
  
  
  
   /* pull filtered pictures from the filtergraph */ 
  
   if(av_buffersink_get_frame(av->buffersink_ctx, av->frame_out) < 0) 
  
   {
  
        printf( "Error while sourcing the filtergraph\n");
  
         break;
  
    }  
  
  
  
  /* do stuff with frame */

  Now, the code works absolutely fine and the video comes out the way I expect it to (vertically flipped for testing purposes).

  The biggest issue I have is that there is a massive memory leak. An high res video will consume 2Gb in a matter of seconds and crash the program. I traced the leak to this piece of code :

  /* push the decoded frame into the filtergraph*/
  
  if (av_buffersrc_add_frame(av->buffersrc_ctx, av->frame_in) < 0) 

  If I bypass the filter by doing av->frame_out=av->frame_in; without pushing the frame into it (and obviously not pulling from it), there is no leak and memory usage is stable.

  Now, I am very new to C, so be gentle, but it seems like I should be clearing out the buffersrc_ctx somehow but no idea how. I’ve looked in official documentations but couldn’t find anything.

  Can someone advise ?

• FFMPEG - Image Overlay Fade Memory Leak

  14 septembre 2017, par DMtd

  Hoping someone can help explain where I may be going wrong with this command. I’m testing an image overlay, including fade in and fade out, with video. The overlay works fine without the fades, but once they are added ffmpeg reaches the end of the process but does not complete. The file stops growing and the process in windows continues to grow, leaking memory. The resulting file is correct (if I force the process to end), I just can’t understand why the process doesn’t complete on its own. Is anyone aware of this memory leak issue with overlay fades and a way to resolve it ?

  ffmpeg -t 00:01:00.000 -i "Input.mxf" -loop 1 -i "Image.png" -vcodec mpeg2video -s 1920x1080 -b:v 50000k -maxrate 50000k -bufsize 3835k -minrate 50000k -r 25 -flags ilme -top 1 -profile:v 0 -level:v 2 -ar 48000 -pix_fmt yuv422p -filter_complex "[1:v]fade=t=in:st=0:d=0.6,fade=t=out:st=59.36:d=0.6[over] ;[0:v][over]overlay=shortest=1 "Output.mxf"

  UPDATE : I found another thread which gave the answer, although I had to reverse the order of my inputs and the mapping for it to work. Simply adding shortest=1 didn’t work. So this is what worked :

  ffmpeg -t 00:01:00.000 -loop 1 -i "Image.png" -i "Input.mxf" -vcodec mpeg2video -s 1920x1080 -b:v 50000k -maxrate 50000k -bufsize 3835k -minrate 50000k -r 25 -flags ilme -top 1 -profile:v 0 -level:v 2 -ar 48000 -pix_fmt yuv422p -filter_complex "[0:v]fade=t=in:st=0:d=0.6,fade=t=out:st=59.36:d=0.6[over] ;[1:v][over]overlay=shortest=1 "Output.mxf"

• Ffmpeg possible sws_scale memory leak

  5 décembre 2024, par Expressingx

  I'm decoding whatever the camera codec is and then always encode it to H264 and more specifically qsv if it is supported. Currently having 2 cameras to test. One is H264 encoding and one is rawvideo. The problem comes with rawvideo. The pixel format is BGR24 and scaling to NV12

  



  I will simplify the code because it is as any other example.

  



  avcodec_send_packet()
// while
avcodec_receive_frame()

// if frame is not EAGAIN convert BGR24 to NV12
if (_pConvertContext == null)
{
    _pConvertContext = CreateContext(sourcePixFmt, targePixFmt);
}

if (_convertedFrameBufferPtr == IntPtr.Zero)
{
    int buffSize = ffmpeg.av_image_get_buffer_size(targePixFmt, sourceFrame->width, sourceFrame->height, 1);
    _convertedFrameBufferPtr = Marshal.AllocHGlobal(buffSize);
     ffmpeg.av_image_fill_arrays(ref _dstData, ref _dstLinesize, (byte*)_convertedFrameBufferPtr, targePixFmt, sourceFrame->width, sourceFrame->height, 1);
}

return ScaleImage(_pConvertContext, sourceFrame, targePixFmt, _dstData, _dstLinesize);


  



  And ScaleImage method

  



  ffmpeg.sws_scale(ctx, sourceFrame->data, sourceFrame->linesize, 0, sourceFrame->height, dstData, dstLinesize);

AVFrame* f = ffmpeg.av_frame_alloc();

var data = new byte_ptrArray8();
data.UpdateFrom(dstData);
var linesize = new int_array8();
linesize.UpdateFrom(dstLinesize);

f->data = data;
f->linesize = linesize;
f->width = sourceFrame->width;
f->height = sourceFrame->height;
f->format = (int)targePixelFormat;

return f;


  



  After that sending the scaled frame to the encoder and receiving it and writing the file. After that I call av_frame_free(&frame) on the frame returned from the method. But when I set breakpoint I can see the address of the frame is the same even after calling av_frame_alloc() and cleaning everytime. And I think this is the reason for the memory leak. If I do deep clone of the f before returning it everything is fine. Why is that happening while the same logic works fine with the other camera ?